add canonical URL distributing caveat #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to 10up#321
jeffpaul
approved these changes
Jun 21, 2019
|
Thanks @arsendovlatyan - looks good to me, nice work! @jeffpaul - I did notice when reviewing the text that we already use several distinct terms in the README to refer to distributed content - sometimes calling it "posts", sometimes "content" and sometimes "stories". It might be worth creating a separate Issue to review and fine fine the language used here and in the plugin itself to make sure we are consistent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #321
Description of the Change
Distributor plugin is modifying canonical URL of distributed post and pointing to original website. In some situations, for example when original post is in password-protected area, this behavior is unexpected.
Alternate Designs
I suggested to add an option in admin or hook, but @adamsilverstein suggests just remove applied filters and add a section in docs.
Benefits
Better documentation?
Possible Drawbacks
I don't see any
Verification Process
Ask colleagues to read the change. It's easy to understand.
Checklist:
Applicable Issues
None